Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Implement method to resolve imports #559

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP: Implement method to resolve imports #559

wants to merge 2 commits into from

Conversation

cvogt
Copy link
Owner

@cvogt cvogt commented Sep 11, 2017

creating a PR for easier comparison

In order to resolve imports, one need to :
- resolve the properties of the xml declaration of the import. This
means that the parents have to be resolved first.
- resolve the properties of the dependencies contained by the import.
This means that when looking up values in the xml, you potentially have
to resolve the transitive poms of the import first.

This therefore parameterise the "lookup" and "properties" method in
order to take the scope into consideration. Typically the argument will
be "transitivePom" or "transitivePom and transitiveImports"

Also changes the order of how the transitivePom and imports are mixed
together.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants